I think I just discovered a security flaw in the way Google handles clicks on the I'm Feeling Lucky button. They allow what essentially amounts to an open redirect, which is bad, bad, bad.

If you visit the following Google URL, you’ll be redirected back to this site, feross.org. Check it out:

http://www.google.com/search?hl=en&q=site:feross.org&btnI=1

Update 8/23/2012: This link does not appear to work anymore.

As long as you pick a query (the part after &q= in the url) that you rank #1 for, this will always redirect you to your intended site. That’s not supposed to happen!

It looks like Google should follow their own advice and prevent open redirect abuse.

Why are open redirects so bad, you ask?

From OWASP:

An open redirect is an application that takes a parameter and redirects a user to the parameter value without any validation. This vulnerability is used in phishing attacks to get users to visit malicious sites without realizing it.

Update

I just reported it to Google. I suppose I should have done so before blogging about it… I figured that they either know about it, or it’s just not a concern for them. Still, I’m curious about why they’d allow this. I’m hoping for a response.

Update 2

They just responded. They know about the issue and claim it’s not a security problem:

In this particular case, we believe the usability and security benefits of a well-implemented and carefully monitored URL redirector tend to** outweigh the perceived risks**.

For a more detailed explanation, check the “URL redirection” section on this page: http://www.google.com/corporate/rewardprogram.html

Regards, [Name Removed], Google Security Team

And some more information from the link they reference:

URL redirection is considered a vulnerability by some members of the security community. The most prevalent argument made in support of this view is that some users, when presented with a carefully crafted link, may be duped into thinking that they will be taken to a trusted page - and will be not be attentive enough to examine the contents of the address bar after the navigation takes place.

That said, it is important to recognize that the address bar is the only reliable content origin indicator available in modern browsers - and therefore, the behavior that would enable URL redirection attacks is inherently unsafe. The panel believes that any user who could be misled by a URL redirector can also be tricked without relying on any particular trusted website to act as a relying party; eliminating URL redirectors will not change this outlook appreciably.

Consequently, the reward panel will likely deem URL redirection reports as non-qualifying: while we prefer to keep their numbers in check, we hold that the usability and security benefits of a small number of well-implemented and carefully monitored URL redirectors tend to outweigh the perceived risks.

I disagree.

**</strong> If the average internet user sees a link to google.com*, clicks it, and then lands on page that claims to be Google, they will feel pretty safe in the fact that they’re on a Google site. *That’s a pretty reasonable assumption to make.

It’s true – users should look at the location bar to verify the URL before giving away login credentials to any site, but this open redirector attack is sure to catch many unsuspecting users by surprise.

Do you agree – is this actually as bad as it looks? Please comment.

(If you liked this, you might like Freedom of Speech on the Internet.)

Thanks for reading! RSS Feed Icon

Feross Aboukhadijeh

I'm Feross, an entrepreneur, programmer, open source author, and mad scientist.

I maintain 100+ packages on npm. All my code is freely accessible on GitHub and funded by my supporters. I now offer a support contract for companies and teams.

I build innovative projects like WebTorrent, a streaming torrent client for the web, WebTorrent Desktop, a slick torrent app for Mac/Windows/Linux, and StandardJS, a JavaScript style guide, linter, and automatic code fixer.

I also work on fun projects like BitMidi, a free MIDI file database, Play, a music video app, and Study Notes, a study tool with college essay examples.

If you enjoyed this post, you should follow me on Twitter.

Or, sign up to get an email whenever I write a post: